Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only check iat if nbf is not used #493

Merged
merged 2 commits into from May 23, 2023
Merged

fix: only check iat if nbf is not used #493

merged 2 commits into from May 23, 2023

Conversation

croensch
Copy link

@croensch croensch commented Mar 5, 2023

See #475

and haven't correctly used the nbf claim

I interpret it as having no nbf claim set. So it was always intended as a fallback.

@bshaffer bshaffer added the v7.0 changes targeted for the next major version label May 3, 2023
bshaffer
bshaffer requested changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we did this, we would also want to support validation of the nbf claim

@bshaffer bshaffer removed the v7.0 changes targeted for the next major version label May 3, 2023
@croensch
Copy link
Author

If we did this, we would also want to support validation of the nbf claim

Sorry i don't understand. The nbf claim is already and will still be validated before this one.

@bshaffer
Copy link
Collaborator

You're right, I didn't realize we were checking nbf before iat. My mistake

@bshaffer bshaffer changed the title only check iat if nbf is not used fix: only check iat if nbf is not used May 22, 2023
@bshaffer bshaffer merged commit 398ccd2 into firebase:main May 23, 2023
7 checks passed
@release-please release-please bot mentioned this pull request May 23, 2023
Merged
@bshaffer bshaffer mentioned this pull request May 23, 2023
Merged
shenkimaro pushed a commit to shenkimaro/php-jwt that referenced this pull request May 30, 2023
@croensch @shenkimaro
fix: only check iat if nbf is not used (firebase#493)
14b9749
shenkimaro pushed a commit to shenkimaro/php-jwt that referenced this pull request May 30, 2023
@croensch @shenkimaro
fix: only check iat if nbf is not used (firebase#493)
5b995f8
@bshaffer bshaffer mentioned this pull request Jun 28, 2023
Closed
shenkimaro pushed a commit to shenkimaro/php-jwt that referenced this pull request Jul 7, 2023
@croensch @shenkimaro
fix: only check iat if nbf is not used (firebase#493)
8f0b97c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@croensch @bshaffer