Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IDE autocompletion #500

Closed
wants to merge 0 commits into from
Closed

Conversation

shenkimaro
Copy link

A typed or constant Class added. This class has all available algorithms. In general, this type of class improves the autocomplete action in IDEs that only search for the class and already show the possibilities, avoiding text typing errors.

@google-cla
Copy link

google-cla bot commented Apr 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bshaffer
Copy link
Collaborator

bshaffer commented May 23, 2023

Thank you for your contribution! This looks great. Consider updating the $supported_algs property in the JWT class as well! And also you'll need to sign the CLA for us to merge this.

Note: This can become an Enum class once support for PHP 8.0 and below is dropped

/**
* openssl SHA384
*/
public const ES384 = 'ES384';
Copy link
Collaborator

@bshaffer bshaffer May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these indentations should be 4 spaces

Suggested change
public const ES384 = 'ES384';
public const ES384 = 'ES384';

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bshaffer. About "you'll need to sign the CLA", I try to push force updating the autor, but the CLA doesn't work yet. The error log says that there is a wrong autor, but through push force I already fixed it. Have you had issues with the CLA before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants