Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow KID index '0' #505

Merged
merged 2 commits into from May 10, 2023
Merged

fix: Allow KID index '0' #505

merged 2 commits into from May 10, 2023

Conversation

ajupazhamayil
Copy link
Collaborator

@ajupazhamayil ajupazhamayil commented May 9, 2023

Fixes #504

@ajupazhamayil
Copy link
Collaborator Author

Note:

php > $nullValue = null;
php > $zero = '0';
php > $text = 'test';
php > print(!isset($nullValue) . PHP_EOL . !isset($zero) . PHP_EOL . !isset($text) . PHP_EOL);
1


php > print(empty($nullValue) . PHP_EOL . empty($zero) . PHP_EOL . empty($text) . PHP_EOL);
1
1

src/JWT.php Outdated Show resolved Hide resolved
@ajupazhamayil ajupazhamayil changed the title fix: Allow KID index 0 fix: Allow KID index '0' May 9, 2023
@bshaffer bshaffer enabled auto-merge May 10, 2023 22:30
@bshaffer bshaffer merged commit 9dc46a9 into firebase:main May 10, 2023
10 checks passed
@ajupazhamayil ajupazhamayil deleted the fixKid branch May 11, 2023 04:41
@ajupazhamayil ajupazhamayil self-assigned this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty kid check breaks in latest version during decode
2 participants