Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for the import docs #507

Merged
merged 2 commits into from May 12, 2023

Conversation

SachinBahukhandi
Copy link

@SachinBahukhandi SachinBahukhandi commented May 11, 2023

Under the section: https://github.com/firebase/php-jwt#exception-handling

try {
    $decoded = JWT::decode($payload, $keys);
} catch (LogicException $e) {
    // errors having to do with environmental setup or malformed JWT Keys
} catch (UnexpectedValueException $e) {
    // errors having to do with JWT signature and claims
}

Added imports to this section.

@google-cla
Copy link

google-cla bot commented May 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bshaffer
Copy link
Collaborator

This looks great but please sign the CLA!

@SachinBahukhandi
Copy link
Author

SachinBahukhandi commented May 12, 2023

This looks great but please sign the CLA!

I had already done it, and forgot to perform a re-scan. Could you please check now?

@bshaffer bshaffer merged commit 6c8f5e7 into firebase:main May 12, 2023
7 checks passed
shenkimaro pushed a commit to shenkimaro/php-jwt that referenced this pull request May 30, 2023
shenkimaro pushed a commit to shenkimaro/php-jwt that referenced this pull request May 30, 2023
shenkimaro pushed a commit to shenkimaro/php-jwt that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants