Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle invalid http responses #508

Merged
merged 5 commits into from Jun 14, 2023
Merged

fix: handle invalid http responses #508

merged 5 commits into from Jun 14, 2023

Conversation

bshaffer
Copy link
Collaborator

fixes #499

src/CachedKeySet.php Outdated Show resolved Hide resolved
Co-authored-by: croensch <christoph.roensch@arcor.de>
@bshaffer bshaffer self-assigned this Jun 14, 2023
Copy link
Collaborator

@yash30201 yash30201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seemed fine, just a small comment regarding test.

tests/CachedKeySetTest.php Show resolved Hide resolved
@bshaffer bshaffer merged commit 91c39c7 into main Jun 14, 2023
7 checks passed
@bshaffer bshaffer deleted the handle-bad-http-response branch June 14, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CachedKeySet does not check HTTP response status code
4 participants