Allow psr/cache ^3.0 #520
Closed
Allow psr/cache ^3.0 #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
requested changes
Jun 20, 2023
There was a problem hiding this comment.
This dependency is in require-dev, so what is the point of this PR? It won't unblock anyone (dev deps aren't installed for transitive dependencies) and it breaks our existing TestMemoryCacheItem.
If we want to support this, we can upgrade TestMemoryCacheItem and drop support for psr/cache:1.0 if you'd like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a breaking change (added return types) but that doesn't impact this library because it doesn't implement the interfaces.