fix: update error text for consistency #528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When these errors are triggered, the value being validated may be different from the value reported in the error message. This fixes that inconsistency.
bshaffer
approved these changes
Jan 22, 2024
bshaffer
changed the title
auto-merge was automatically disabled
January 29, 2024 23:11
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #492 where an inconsistency was introduced. When triggering these error messages, if the value should be rounded up, then the value in the error message won't match the value being checked. Given we're talking about fractions of a second, this shouldn't cause any real-world impact. This inconsistency may make debugging edge cases difficult, leading to confusion. This confusion may lead do setting too much leeway in timing settings.