[Firecms] Add support for typesense search #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeringPhil
reviewed
May 2, 2023
lib/.gitignore
Outdated
There was a problem hiding this comment.
Depending on how Camberi are deploying and what their CI/CD looks like, yarn.lock might actually need to be committed to the repo so I'm not sure that this change will be accepted if you mess with that 🤔
There was a problem hiding this comment.
That is correct, yarn.lock should not be excluded from Git
fgatti675
reviewed
May 3, 2023
| @@ -75,7 +75,8 @@ | |||
| "react": "^18.0.0", | |||
| "react-dom": "^18.0.0", | |||
| "react-router": "^6.2.0", | |||
| "react-router-dom": "^6.2.0" | |||
| "react-router-dom": "^6.2.0", | |||
| "typesense": "1.5.3" | |||
There was a problem hiding this comment.
Could you move this dependency to peer dependencies?
So that only users who want to use it can pull it in.
Thanks!
|
@yash1200 Hello! Is this ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds supports for typesense search and also add
yarn.lockfile to gitignore.