Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version information for in-VM agent, shim, firecracker-conta… #377

Merged
merged 4 commits into from
Jan 20, 2020
Merged

Add version information for in-VM agent, shim, firecracker-conta… #377

merged 4 commits into from
Jan 20, 2020

Commits on Jan 9, 2020

  1. Add -version flag to the in-VM agent 

    Investigating issues like firecracker-microvm#370 will be easier if the agent can report
the version.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
    @kzys
    kzys committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    80f87c9 View commit details
    Browse the repository at this point in the history

  2. Fill out containerd's Revision variable correctly 

    As like containerd's Makefile, we can fill out version.Revision to
make our life easier.

https://github.com/containerd/containerd/blob/0a1f2b40642e54ed06cd0a22cdf6025cbe70853c/Makefile#L24

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
    @kzys
    kzys committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    6bef84d View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Log aws.firecracker's version since supporting -version is hard 

    Because the shim's flag parsing is owned by containerd's shim package,
supporting -version/-v is not straightforward. Instead the binary logs
the version.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
    @kzys
    kzys committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    a731d81 View commit details
    Browse the repository at this point in the history

  2. Clarify the source of the version strings 

    Since the version strings won't be like "1.2.3", it would be better to
communicate the way we generate the strings.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
    @kzys
    kzys committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    07d3955 View commit details
    Browse the repository at this point in the history