Upgrade to node v12

[duncanjbain]

Hi all,

This PR should hopefully close the issues mentioned in #2580.

The only thing I'm struggling with is rthe efactoring due to TextEncoder and TextDecoder now being global objects in Node.

I've made some changes to as an example to src/test/components/MenuButtons.test.js but the Jest test fails due to ReferenceError: TextEncoder is not defined.

I'm not sure why the test wont pass, is it due to the Jest environment not supporting TextEncoder as a global object? If this was the case I guess several other tests would likely fail also.

I'm pretty to new to JS/Node so I've probably missed something pretty obvious!

[julienw]

Thanks for the patch, I'll check it our more closely on monday.
I think I fixed the netlify deploy by configuring node v12 on their settings (you can't do that).
For appveyor you can try specifying just "12" instead of a precise version. They should take the most recent v12 they have already installed.

[duncanjbain]

Looks like AppVeyor doesn't use the latest LTS version of Node.

[julienw]

For appveyor, looks like we can install specific versions that aren't preinstalled, see:

https://www.appveyor.com/docs/lang/nodejs-iojs/

Would you please try that ?

[julienw]

Thanks for the changes! Here are my small suggestions, I think everything will pass with this :-) Tell me what you think!

[codecov]

Codecov Report

Merging #2581 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2581      +/-   ##
==========================================
+ Coverage   86.55%   86.57%   +0.01%     
==========================================
  Files         217      217              
  Lines       17168    17079      -89     
  Branches     4436     4405      -31     
==========================================
- Hits        14860    14786      -74     
+ Misses       2112     2099      -13     
+ Partials      196      194       -2     

Impacted Files	Coverage Δ
src/components/timeline/ActiveTabResourceTrack.js	81.63% <0.00%> (-1.95%)	⬇️
src/actions/app.js	78.94% <0.00%> (-1.36%)	⬇️
src/profile-logic/sanitize.js	98.93% <0.00%> (-0.07%)	⬇️
src/profile-logic/marker-data.js	93.01% <0.00%> (-0.03%)	⬇️
src/profile-logic/profile-data.js	89.95% <0.00%> (-0.03%)	⬇️
src/reducers/app.js	98.38% <0.00%> (-0.02%)	⬇️
src/reducers/url-state.js	96.81% <0.00%> (-0.02%)	⬇️
src/utils/string.js	100.00% <0.00%> (ø)
src/components/app/MenuButtons/Publish.js	75.72% <0.00%> (ø)
src/components/sidebar/CallTreeSidebar.js	93.75% <0.00%> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9366269...f7e742f. Read the comment docs.

[duncanjbain]

Looks like everything is passing now @julienw :)

[julienw]

I noticed a last change to be made =>

profiler/.gitpod.yml

Line 4 in 9366269

- before: nvm install 10

I think this can be "12" and not a specific version.

Can you add it and then I can merge! Thanks a lot :-)

Edit: ah don't worry, I can add it myself :)

[julienw]

Thanks!