ci: Attempt to fix some flaky Elixir unit tests #4927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
kind/chore
Terraform Cloud Plan Output |
jamilbk
changed the title
jamilbk
changed the title
Performance Test ResultsTCP
UDP
|
jamilbk
commented
May 9, 2024
| @@ -91,7 +90,13 @@ defmodule Domain.Mocks.OpenIDConnect do | |||
| "request_parameter_supported" => false | |||
| } | |||
|
|
|||
| Plug.Conn.resp(conn, 200, Jason.encode!(attrs)) | |||
| # Process may not be alive in slow CI environments | |||
There was a problem hiding this comment.
| @@ -134,7 +134,8 @@ defmodule Web.AcceptanceCase do | |||
| if env = System.get_env("E2E_DEFAULT_WAIT_SECONDS") do | |||
| String.to_integer(env) | |||
| else | |||
| 2 | |||
| # GitHub shared runners can be very slow during peak hours | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@jamilbk it's already 5 seconds on CI: E2E_DEFAULT_WAIT_SECONDS in
AndrewDryga
reviewed
May 10, 2024
| Plug.Conn.resp(conn, 200, Jason.encode!(attrs)) | ||
|
|
||
| # Process may not be alive in slow CI environments | ||
| if Process.alive?(test_pid) do |
There was a problem hiding this comment.
This doesn't fix anything, the issue happens when Plug process is trying to read from Bypass process. So when the Plug process is terminated with the test process, the bypass can't finish reading the full response. And it doesn't matter if the response code is 503 or 401, has body or not, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes some of the flaky unit tests that crop up from time to time.
Refs #4635