Don't pass invalid NODE_OPTIONS to worker (#44)

Co-authored-by: fisker <lionkay@gmail.com>
fisker · Apr 17, 2024 · 4465bd2 · 4465bd2
1 parent 23c0aab
commit 4465bd2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/source/threads-worker.js b/source/threads-worker.js
@@ -32,7 +32,6 @@ class ThreadsWorker {
     const lock = IS_PRODUCTION ? {} : new Lock()
 
     const worker = new Worker(WORKER_FILE, {
-      execArgv: process.env.NODE_OPTIONS?.split(' '),
       workerData: {
         workerRunningSemaphore: lock.semaphore,
         ...this.#workerData,

diff --git a/tests/loaders.test.js b/tests/loaders.test.js
@@ -27,15 +27,19 @@ async function run({type}) {
     )
     await fs.writeFile(
       file,
-      `
-      import print from ${JSON.stringify(module.href)}
-      console.log(JSON.stringify(print(), undefined, 2))
-    `,
+      /* Indent */ `
+        import print from ${JSON.stringify(module.href)}
+        console.log(JSON.stringify(print(), undefined, 2))
+      `,
     )
 
     return await execaCommand('yarn node foo.mjs --silent', {
       cwd: directory,
-      env: {FORCE_COLOR: '0'},
+      env: {
+        FORCE_COLOR: '0',
+        // https://github.com/fisker/make-synchronized/pull/44
+        NODE_OPTIONS: '--max-old-space-size=4096',
+      },
     })
   } finally {
     await fs.rm(directory, {force: true, recursive: true})