Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass invalid NODE_OPTIONS to worker #44

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Don't pass invalid NODE_OPTIONS to worker #44

merged 2 commits into from
Apr 17, 2024

Commits on Apr 15, 2024

  1. fix(worker): Don't parse invalid NODE_OPTIONS 

    This was causing downstream projects like prettier-synchronized to break
when encountering V8 options like `--max-old-space-size`.

The option itself shouldn't be needed since execArgv values are
inherited from the parent thread by default.

See: https://nodejs.org/api/worker_threads.html#new-workerfilename-options

Related: webpack/webpack#14859
    @donovanglover
    donovanglover committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a1ba2e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Add test

    @fisker
    fisker committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c88f397 View commit details
    Browse the repository at this point in the history