Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existing REST APIs with gRPC #2706

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shubham4443
Copy link
Contributor

Description

This PR is the first step of replacing all the existing APIs which are written in REST architectural style with gRPC. gRPC has benefits over REST such as speed, communication protocol (gRPC uses HTTP/2).

Please note that -

  1. This is still at a proof-of-concept stage.
  2. We are beginning with executor first.
  3. generate-proto.sh has protobuf related commands for reference.
  4. executor.proto has a sample UnaryEcho service for testing purpose.
  5. the executor gRPC server is running at port 50051 along with the HTTP server. This port is exposed on the pod as well on the service.

Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #2706 (783617d) into main (a9d5542) will decrease coverage by 1.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2706      +/-   ##
==========================================
- Coverage   21.12%   19.96%   -1.17%     
==========================================
  Files          65       64       -1     
  Lines        7215     7094     -121     
==========================================
- Hits         1524     1416     -108     
+ Misses       5577     5572       -5     
+ Partials      114      106       -8     
Flag Coverage Δ
unittests 19.96% <0.00%> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/router/functionHandler.go 10.94% <0.00%> (-0.13%) ⬇️
pkg/fission-cli/util/util.go 2.47% <0.00%> (-0.07%) ⬇️
pkg/poolcache/poolcache.go
pkg/utils/serviceaccount.go 78.60% <0.00%> (+0.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant