Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing code comments #2927

Merged
merged 1 commit into from
May 20, 2024
Merged

Fixing code comments #2927

merged 1 commit into from
May 20, 2024

Conversation

eveneast
Copy link
Contributor

Description

Fix some comments

Which issue(s) this PR fixes:

No

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@eveneast
Copy link
Contributor Author

Anything need I to do? If have, Please feel free to tell me.

@sanketsudake sanketsudake changed the title Fix some comments Fixing code comments May 7, 2024
@sanketsudake
Copy link
Member

@Mergifyio rebase

@eveneast @sanketsudake
Fix some comments
b6e3a9f 
Signed-off-by: eveneast <qcqs@foxmail.com>
@mergify Mergify
Copy link

mergify bot commented May 15, 2024

rebase

✅ Branch has been successfully rebased

@sanketsudake sanketsudake merged commit 3e43c07 into fission:main May 20, 2024
9 checks passed
@sanketsudake sanketsudake self-requested a review May 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake Awaiting requested review from sanketsudake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eveneast @sanketsudake