Fixed an error when using the command to download src

[waitstory]

issue: #2938

Description

Fixed an error when using the command to download src

Which issue(s) this PR fixes:

Fixes #2938

Testing

Checklist:

• I ran tests as well as code linting locally to verify my changes.
• I have done manual verification of my changes, changes working as expected.

[sweep-ai]

Sweep: PR Review

Sweep has finished reviewing your pull request.

pkg/fission-cli/cmd/package/util/util.go

The changes import the os/exec package and replace the os.Rename function with the Unix mv command executed via exec.Command.

Potential Issues

• Replacing os.Rename with exec.Command("mv", path, fileName) introduces a dependency on the Unix mv command, which may not be available or behave consistently across different environments.

fission/pkg/fission-cli/cmd/package/util/util.go

Lines 221 to 222 in f3c033f

	cmd := exec.Command("mv", path, fileName)
	_, err = cmd.Output()

---

[sanketsudake]

Just following golang/go#41487 so see if there is better way to handle this issue.

[waitstory]

Just following golang/go#41487 so see if there is better way to handle this issue.就按照 golang/go#41487 看看是否有更好的方法来处理这个问题。

There seems to be no direct solution to the problem

[sanketsudake]

Probably we can just make this function simple without using rename or mv and getting rid of the temp file.

func WriteArchiveToFile(fileName string, reader io.Reader) error {
	// Create the target file directly
	file, err := os.Create(fileName)
	if err != nil {
		return err
	}
	defer file.Close()

	// Copy data from the reader to the target file
	_, err = io.Copy(file, reader)
	if err != nil {
		return err
	}

	// Change the permissions of the target file
	err = os.Chmod(fileName, 0644)
	if err != nil {
		return err
	}

	return nil
}

[waitstory]

Seems like a good idea

[sanketsudake]

@waitstory Would you like to make the above change or should I raise a separate PR?

[waitstory]

Let me make the change and submit it