Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having trouble setting up correctly #79

Closed
mainrs opened this issue Dec 22, 2020 · 3 comments
Closed

Having trouble setting up correctly #79

mainrs opened this issue Dec 22, 2020 · 3 comments

Comments

@mainrs
Copy link

mainrs commented Dec 22, 2020

Hey! I have troubles setting this action up correctly. I think I configured it correctly but the jobs that I specified using the if-clause still get all triggered.

Here is the workflow file: https://github.com/Spotifyd/spotifyd/blob/master/.github/workflows/ci.yml
And here is the PR that triggers all steps, even though it should only trigger the pre_job one: Spotifyd/spotifyd#743

I've tried to set the action up so it only triggers codestyle, lint and check if files inside of src/ change or one of the following files: Cargo.toml, Cargo.lock, .github/workflows/ci.yml.

I'd really really appreciate your help, as we are having troubles with protected branches and GitHub's paths feature. All our PRs hang and wait for checks :(

@fkirc
Copy link
Owner

fkirc commented Dec 22, 2020

Your setup seems to be correct, you have configured the paths feature as expected.
However, this paths feature works very different than GitHub's native paths feature.
I explained the differences to GitHub's native paths feature in #59.

My feeling is that your repo has very few successful checks that are parents of the commits that you want to path-skip.
If such successful parent-checks cannot be found, then this Action won't path-skip anything.

@fkirc
Copy link
Owner

fkirc commented Dec 22, 2020

I have to admit that the logging-situation was bad, which made it hard to see why paths-skipping failed.
Therefore, I published #80 as an attempt to improve the logging-situation.
So if you upgrade to v3.3.0, then you should see exactly why something was skipped or not skipped.
Feel free to re-open this issue if the result is still not understandable with the logging of v3.3.0.

@fkirc fkirc closed this as completed Dec 22, 2020
@mainrs
Copy link
Author

mainrs commented Dec 22, 2020

That could actually be it! The part that through me off was that the PR that I opened to change the workflow file worked as indented in the first place, it only ran the pre_job and nothing else, as it's path wasn't specified inside the array. I then concluded that everything worked correctly without problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants