-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor typed om implementation #226
base: master
Are you sure you want to change the base?
Refactor typed om implementation #226
Conversation
I’d also move |
9e56959
to
b5a0d93
Compare
Yeah.. That makes sense. I didn't realize #221 was merged. I've moved Do you want me to split out some of the classes, or should we do that in a separate PR? |
It can go in this PR, as it's all about reorganization. |
b5a0d93
to
d3a49d3
Compare
Moved the token classes into a separate file now, when it comes to the CSSNumericValue classes, I think they should stay in proxy-cssom? |
Yes. That way, eventually, the whole cssom block can graduate to being its own package. |
Re-reading my comment I wasn't clear here. I interpreted "staying in CCSOM" as stay in the folder. What I mean is: I'd split off these classes into their own files, one class per file. |
d3a49d3
to
9febccd
Compare
Got it :) I split the classes into their own files and switched from using a WeakMap for the internals to using private class fields. |
Moving the internal implementation of typed om into its own folder.
CSSNumericValue and subclasses are split into separate files.