Dont parse stylesheets controlled by aphrodite #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flackr
reviewed
Feb 16, 2024
flackr
reviewed
Feb 20, 2024
flackr
reviewed
Feb 20, 2024
src/scroll-timeline-css.js
Outdated
| // Don’t touch empty style tags nor tags controlled by aphrodite. | ||
| // Details at https://github.com/Khan/aphrodite/blob/master/src/inject.js, | ||
| // but any modification to the style tag will break the entire page. | ||
| if (el.innerHTML.trim().length === 0 || 'aphrodite' in item.dataset) { |
There was a problem hiding this comment.
I think s/item/el ? I don't see item defined
There was a problem hiding this comment.
omg Tuesday is getting me, and my over-reliance on typescript. Thank you, updated!
flackr
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158.