-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New option to hide cursor for DEs other than GNOME and KDE #3607
base: master
Are you sure you want to change the base?
New option to hide cursor for DEs other than GNOME and KDE #3607
Conversation
GRIM provides a -c option to display cursor in screenshots. I added a new option to make us of this functionality. However, technically this option needs to be hidden/disabled under GNOME and KDE. I may address this in a later commit.
Thanks for the PR. I believe the correct course UX is to have only and only one checkbox that works universally on all DEs and OSs. What I mean is that the user should not care which feature they should toggle based on what software stack they are using. So if we cannot turn off cursor in Gnome Wayland or KDE or Windows, we should somehow show a message to the user and inform them why the checkbox is disabled. In this implementation the Windows, Mac, and BSD users will just get a disabled checkbox without any explanation, and the Gnome and KDE users will get different tooltip. I believe it is better if
This PR also addresses #604 in a way (giving control over showing cursor in Wayland) |
Aesthetically I like it, but the point is that users rarely check the tooltip for more info. How about adding a ℹ️ or something similar at the end of such items that kind of invite/attract the user to click/hover to get the reason on why this is red. Btw, thanks for your efforts and responsiveness 👍 |
Now red text will show above the cursor hiding option if the desktop environment does not support setting the behaviour
@mmahmoudian Thank you for your kind words. On second thought I think adding a text is a better idea precisely because of the reason you've mentioned. I just deleted my comment because my design was such a minor difference that I didn't think it'd be worth mentioning... Besides, whether an unsupported environment actually grabs the cursor or not is outside our control, so informing the user about the issue on first sight resolves the ambiguity of a disabled-but-checked box. In the end this is what it looks like: |
screenGrabber.cpp
, the application decides to use either a DBus interface or the wlroots-basedgrim
program depending on the desktop environment. Unfortunately, from what I understand, KDE and GNOME do not support wlr protocols, and the DBus interface does not provide an option to show or hide the cursor. Therefore, my changes (should) only apply to DEs that can utilize grim.grim
includes the cursor in screenshots with-c
argument. This PR basically just allows passing this option.Partially resolves #3582, #604