Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add logic for converting Schema to dict in @swag_from #465

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michaelbukachi
Copy link

This fixes #464

@michaelbukachi
Copy link
Author

Hey @billyrrr, do you mind reviewing this?

@billyrrr
Copy link
Member

Hey @billyrrr, do you mind reviewing this?

Definitely, but, to be honest, the code base of flasgger is difficult to be grasped in full even for me. I would have to review several usages of convert_schema method, or maybe even do a few refactors before being able to review or merge this change.

@michaelbukachi
Copy link
Author

Hey @billyrrr, do you mind reviewing this?

Definitely, but, to be honest, the code base of flasgger is difficult to be grasped in full even for me. I would have to review several usages of convert_schema method, or maybe even do a few refactors before being able to review or merge this change.

I just copied the functionality from SwaggerView i.e

specs.update(convert_schemas(specs, definitions))

In swag_from marshmallow schemas were not being converted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marshmallow Schema parameters fails with @swag_from
2 participants