Update utils.py #468
Open
Update utils.py #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyrrr
requested changes
Apr 13, 2021
| if hasattr(method, '__func__') else method | ||
| setattr(func, 'swag_type', 'yml') | ||
| setattr(func, 'swag_path', file_path) | ||
| if doc_dir and isinstance(doc_dir, Iterable): |
There was a problem hiding this comment.
isinstance('./examples/docs/', Iterable) would evaluate to True. Don't worry about this fix tho. I plan to copy a function from marshmallow source code ```def is_iterable_but_not_string(obj) -> bool:
| @@ -13,7 +13,7 @@ | |||
| app = Flask(__name__) | |||
| app.config['SWAGGER'] = { | |||
| 'title': 'Flasgger Parsed Method/Function View Example', | |||
| 'doc_dir': './examples/docs/' | |||
There was a problem hiding this comment.
Ideally, we want to maintain backward compatibility, even in our examples, but I would agree with your change to promote this new feature.
| func = method.__func__ \ | ||
| if hasattr(method, '__func__') else method | ||
| setattr(func, 'swag_type', 'yml') | ||
| setattr(func, 'swag_path', file_path) |
There was a problem hiding this comment.
What would happen if there are multiple doc_dir? Will setattr(func, 'swag_type', 'yml') override previous definition of func? It would be better if there is a unittest or test case to demonstrate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple doc_dir can be set in the swagger configuration file
config.py