New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Test in frontend components #1684
Conversation
Great work, other then the mentioned comments, I think this misses one crucial thing. It needs to be added to the github pipeline. Maybe as a new pipeline step, so that we can validate these pass on every merge. |
Cool i make adjustments during the week
|
@razzeee I made the adjustments if you can review again |
Hrm, seems like it's not running on our CI |
it seems that jest is giving an error because of the typescript, I will try to adjust the configuration. i dont know how resolve it, tried rollback version and all settings but not work |
I guess we're running into vercel/next.js#40183 |
I'm trying to apply the issue solution, but it's hard to find packages that use esm |
It also makes it sound like it's an regression on their end, so maybe if they fix it upstream we could wait for it. |
I tried downgrading jest to 27 and next to 13.2 and 13.1 don't work, but I if you remove node_modules and yarn.lock works but if you remove just remove node_modules not works, I don't know why |
Issue #1184
Flows to be tested