Native Wayland support

[sebastian-de]

Tested on KDE Plasma Wayland/X11 with amdgpu

--ozone-platform-hint=auto should be enough once electron/electron#34937 finds its way into the Electron version used by Arduino IDE.

Thanks for creating this flatpak!

[flathubbot]

Started test build 113262

[flathubbot]

Build 113262 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110864/cc.arduino.IDE2.flatpakref

[flathubbot]

Started test build 113276

[flathubbot]

Build 113276 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110878/cc.arduino.IDE2.flatpakref

[flathubbot]

Started test build 113277

[flathubbot]

Build 113277 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110879/cc.arduino.IDE2.flatpakref

[flathubbot]

Started test build 113286

[flathubbot]

Build 113286 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110888/cc.arduino.IDE2.flatpakref

[sebastian-de]

Removing ~/.var/app/cc.arduino.IDE2 shouldnt affect the ide in any way as its files are not stored there and in a worse case scenario would just reset the ide.

Yes, that's what I wanted to do - to simulate a fresh install.

Do me a favour and try removing the app and then installing it again. It looks like part of the application might be missing.

The result is the same:

• first start with native wayland -> segfault
• first start with xwayland -> success

After the first start I can enable wayland and it works fine.

So I guess we should wait for an upstream electron bump before we enable this.

[hfiguiere]

To me as long as it is not the default in the platform it shouldn't be merged.

[hfiguiere]

And by platform, here I mean Electron.

[sebastian-de]

The primary reason I prefer native Wayland is that scaling doesn't work correctly with XWayland and therefore XWayland applications are blurry on HiDPI-screens.

But I'm fine with enabling Wayland locally for me.

[joshuag1000]

To me as long as it is not the default in the platform it shouldn't be merged.

This makes sense. As the advice for electron apps on flathub's documentation is not to enable wayland.
And with the sudden issue that @sebastian-de is experiencing with the app i think we should hold off on wayland support until electron better supports wayland natively (without enabling potentially experimental options) and the default recommended options for the electron platform are changed to enable wayland.

@sebastian-de i understand that xWayland is not perfect but after hearing what @hfiguiere said until those two requirements are met i agree with them on NOT merging this and if you truly want wayland native then you would be better patching this in yourself.
I would consider making these changes to a beta branch but i believe that this may cause confusion with people thinking that the branch is for the nightly builds or an actual beta run of the IDE.

If things change in the future then we can look at this again but until then i'm going to close this pr and pin it for future reference.