Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.00 and Electron 14 #39

Closed
wants to merge 2 commits into from
Closed

Conversation

vchernin
Copy link
Collaborator

@vchernin vchernin commented Sep 20, 2021

If this works this is the first Flatpak app on Electron 14 with the portal file chooser (that I know of).
Only for testing purposes since its an RC.

@flathubbot
Copy link
Contributor

Started test build 60359

@flathubbot
Copy link
Contributor

Build 60359 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/58224/com.mattermost.Desktop.flatpakref

@vchernin
Copy link
Collaborator Author

I have no idea why this is so much trouble...
I tried flatpak run --env=GTK_USE_PORTAL=1 com.mattermost.Desktop on various distros and it's just not working.

@flathubbot
Copy link
Contributor

Started test build 60988

@flathubbot
Copy link
Contributor

Build 60988 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/58835/com.mattermost.Desktop.flatpakref

@flathubbot
Copy link
Contributor

Started test build 60989

@flathubbot
Copy link
Contributor

Build 60989 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/58836/com.mattermost.Desktop.flatpakref

@vchernin
Copy link
Collaborator Author

vchernin commented Sep 24, 2021

@squalou @tristan957 I can't get this Electron 14 app working with the file chooser portal either... any ideas?

If not I think I'll open up an issue in electron's repo.

Edit: Maybe it's because of the changes to this file since the PR was merged.

@tristan957
Copy link

I don't think you need to set GTK_USE_PORTAL=1 within the flatpak itself. The portal should "just work" ™️

I recommend hopping into #flatpak on matrix.org. I would also recommend checking getting a d-bus monitor and watching the the calls to see if any portal action is happening. Also make sure you have the portal actually installed on the host machine

@tristan957
Copy link

I see you are already in the room. Someone there might have some sage advice.

@vchernin
Copy link
Collaborator Author

Yeah I don't see any calls to FileChooser in Bustle.. and I've asked in #flatpak a couple times but I didn't get any response. I'm afraid this issue is in unknown territory.

The portal defintely works with other apps just fine (well ones that support it anyway). I'm on Fedora so I usually like trying out shiny Linux stuff :)

@tristan957
Copy link

tristan957 commented Sep 27, 2021

Honestly I have no clue. The user experience behind these features seems very hard to discover.

I assuming you already checked that xdg-desktop-portal-kde installed and xdg-desktop-portal-gnome/gtk is not installed and that GTK_USE_PORTAL=1 is exported in your host environment?

I guess that question was redundant with your previous message. You could try debugging electron and seeing if it hits the gtk native file chooser code path.

@vchernin
Copy link
Collaborator Author

vchernin commented Oct 2, 2021

I made an issue for this, hopefully someone has some ideas on what’s wrong electron/electron#31258

I don’t really know how to debug Electron, hopefully someone does though. If I find time one day maybe I’ll try figure it out.

@vchernin vchernin closed this Oct 13, 2021
@vchernin vchernin deleted the test-RC-E14 branch October 13, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants