Fix issue onblur event #2903
Open
Fix issue onblur event #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Event.path into Event.composedPath()
Update input attribute value
Added vi as Vietnamese code language
Fix an issue at MonthSelect plugin related with aria-labels values
mvorisek
reviewed
Jun 15, 2023
| - Used in conjunction with altInput config since this will prevent the update value of the hidden input. | ||
| - With this approach issues related with different assigned values to this input will be fixed since it must be | ||
| Controlled by developer at the OnSelectedDate callback */ | ||
| updateInputVal: boolean; |
There was a problem hiding this comment.
I am little againts adding more and more IMHO quite unneded options. Can the solution be made without the additional option?
Anyway, please add a test to reproduce the initial problem and assert it is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isue was introduced with the v4.6.13 and the flatpickr loses the support of update the value when the blur event is triggered. This issue was introcuded on the commit #2668, with the validation of the input value and comparing dates.
The previous approach block the update of the values when a past date occur or typing, without press enter. The library just need to close the ballon to update the values. Now with the fix, we prevent the twice triggering of the event and update the value on close the ballon.