Review comments from issues/829-nullsafety #919
Conversation
Removes deprecated properties, updates documentation and changed bounds getCenter to a getter.
|
Thanks for your effort! :) |
There was a problem hiding this comment.
NonCachingNetworkTileProvider() is the default provider, not CachedNetworkTileProvider()! In fact CachedNetworkTileProvider() doesn't actually exist. Honestly, I think the tile providers need a rename! NetworkTileProvider() actually uses NetworkImageWithRetry() which (as far as I understand) doesn't cache tiles, and NonCachingNetworkTileProvider() actually uses NetworkImage() which (as far as I understand) also does cache tiles, but not very well and not very flexibly.
I'd change it to:
/// Provider to load the tiles. The default is `NonCachingNetworkTileProvider()` which
/// doesn't cache tiles and won't retry the HTTP request. Use `NetworkTileProvider()` for
/// a provider which will retry requests. For the best caching implementations, see the
/// flutter_map readme. 
Fixed! I believe we should create a ticket for looking further into the documentation around caching and fix it. And I don't think we have to fix it for the null-safety release (which hopefully would happen soon...) |
|
Thanks, I think that's a bit better. I'm aiming to clarify the documentation around caching with #913! Update @andreandersson: I've changed it again! I wish Flutter's docs could agree and whoever decided that the only provider that did cache should be called ' |
* Add actions/stale@v3 GitHub Action patched version * updated to latest master version * updated dependcies to compile again * updated latlong import * migrated to unsound null safety * removed .packages from repository * small fixes * Update lib/src/core/point.dart Co-authored-by: Sata51 <vm.mathieu@gmail.com> * Update pubspec.yaml Co-authored-by: Sata51 <vm.mathieu@gmail.com> * Update lib/src/gestures/latlng_tween.dart Co-authored-by: Sata51 <vm.mathieu@gmail.com> * type '_ControllerStream<LatLng?>' is not a subtype of type 'Stream<LatLng>' of 'stream' * changes according to review * made key nullable * made rebuild nullable again * Fix polyline border drawing * corrected typo in dependency_overrides * Removed unnecessary null-checks * Limit number of purges in TileLayer and cancel pending on dispose * Fix error messages in mocked classes * Set ready to true always (state is never null) * make bounds, getBounds and getCenter null safe * use http.RetryClient instead of flutter_image * formatting * add change notes * Added example page for NetworkTileProvider * Added dependency on null safe version 0.17.0 of package intl (would not build without it) * Changed to master branch of flutter_image that is now null-safe * Change override of package flutter_image to new location in flutter packages * Update git repo link * Fix typos * Sort dependencies * Reformat and improve pub score * Upgraded to flutter_image ^4.0.1 * Reformatted files to standard settings * Reformatted crs.dart that wasn't changed using command line * Random Fixes Everywhere (#910) * Update git repo link * Fix typos * Sort dependencies * Improve pub score * remove TODO * Clarification of all options available for offline mapping (#913) * Update README.md - Clarified all options for offline mapping - Fixed some capitalisation inconsistencies. * Update README.md * fix Group Layer Options constructor wrong nullability (#921) Co-authored-by: 6y <tlserver6y@gmail.com> * null check regex in template() * re-apply #913 into null safety branch * Review comments from issues/829-nullsafety (#919) * fix: remove deprecated properties Removes deprecated properties, updates documentation and changed bounds getCenter to a getter. * fix: simplify center getter * docs: improve documentation for NetworkTileProvider * docs: update documentation for tileProvider * dart format * make urlTemplate required, make throttleSTreamTransformerWithTrailingCall updateInterval required. * use late final where possible * revert making urlTemplate non-nullable Co-authored-by: John Ryan <ryjohn@google.com> Co-authored-by: escamoteur <github@burkharts.net> Co-authored-by: Sata51 <vm.mathieu@gmail.com> Co-authored-by: alt <ali.tazik@gmail.com> Co-authored-by: Ahmed-gubara <ahmed.gubara93@gmail.com> Co-authored-by: josxha <34318751+josxha@users.noreply.github.com> Co-authored-by: Nico Mexis <nico.mexis@kabelmail.de> Co-authored-by: Luka S <58115698+JaffaKetchup@users.noreply.github.com> Co-authored-by: 6y <tlserver@yahoo.com> Co-authored-by: 6y <tlserver6y@gmail.com> Co-authored-by: André Andersson <andre.andersson@zenon.se>
No description provided.