Fleet UI: Add reminder banners for ABM and APNs expirations #19085
Conversation
| @@ -65,8 +65,8 @@ export default { | |||
| MACADMINS: `/${API_VERSION}/fleet/macadmins`, | |||
|
|
|||
| // MDM endpoints | |||
| MDM_APPLE: `/${API_VERSION}/fleet/mdm/apple`, | |||
There was a problem hiding this comment.
these endpoints (mdm/apple and mdm/apple_bm are deprecated and now /apns and /abm respectively
RachelElysia
changed the title
RachelElysia
added
the
~assisting g-mdm
|
👀 |
| @@ -61,6 +63,8 @@ const App = ({ children, location }: IAppProps): JSX.Element => { | |||
| setCurrentUser, | |||
| setConfig, | |||
| setEnrollSecret, | |||
| setABMExpiry, | |||
| setAPNsExpiry, | |||
There was a problem hiding this comment.
We could also cleanup sandbox code while we're at it
There was a problem hiding this comment.
I didn't want to scope creep cleaning up the entire <SandboxGate/> in this banners PR estimated to be a 2 right before I took a week vacation.
| @@ -1,33 +1,5 @@ | |||
| .apple-bm-terms-message { | |||
| @@ -19,6 +19,8 @@ import { | |||
| intlFormat, | |||
| intervalToDuration, | |||
| isAfter, | |||
| isBefore, | |||
| /> | ||
| <div className={`${baseClass}--animation-disabled`}> | ||
| {renderAppWideBanner()} | ||
| <SandboxGate |
There was a problem hiding this comment.
we can take out the SandboxGate
There was a problem hiding this comment.
Limiting scope as I'm leaving in 5 work hours.
| {renderAppWideBanner()} | ||
| <SandboxGate | ||
| fallbackComponent={() => ( | ||
| <SandboxExpiryMessage |
| config?.license.expiration || "" | ||
| ); | ||
|
|
||
| const showingAppWideBanner = |
There was a problem hiding this comment.
I wonder if a more directly linked way to check this would be more bug-proof? Not a deal breaker.
There was a problem hiding this comment.
Yeah, I just built on what's already in there. Definitely consider a refactor if more time was allotted.
RachelElysia
force-pushed
the
mdm-expiration-banners
branch
from
00c5397
to
756451a
Compare
Issue
Cerra #11544
Description
Note: This PR builds on the license-expiration PR which should be reviewed and merged first as it will likely cause merge conflicts.
Screen recording
https://www.loom.com/share/79108625899a4418af7343536ec26d56?sid=18709263-d797-4c46-afa9-c79cf18f13da
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.