terraform: add flexkube_containers resource

[invidian]

As a preparation to resolve #40 and #42, to have some basic patterns defined, which can be then used in more complex scenarios.

TODOs:

• Add tests
• Add support for all other parameters

Follow-up work:

• Make sure Terraform does not leak secrets (we might skip 1:1 scheme mapping in favor of more secret-friendly one)

[invidian]

Sample output:

[codecov]

Codecov Report

Merging #66 into master will decrease coverage by 0.74%.
The diff coverage is 92.24%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   84.03%   83.29%   -0.75%     
==========================================
  Files          36       57      +21     
  Lines        2186     2909     +723     
==========================================
+ Hits         1837     2423     +586     
- Misses        257      385     +128     
- Partials       92      101       +9

Impacted Files	Coverage Δ
pkg/container/containers.go	68.32% <100%> (+0.58%)	⬆️
cmd/terraform-provider-flexkube/flexkube/ssh.go	100% <100%> (ø)
...rraform-provider-flexkube/flexkube/config_files.go	100% <100%> (ø)
.../terraform-provider-flexkube/flexkube/container.go	100% <100%> (ø)
cmd/terraform-provider-flexkube/flexkube/ports.go	100% <100%> (ø)
...orm-provider-flexkube/flexkube/container_status.go	100% <100%> (ø)
cmd/terraform-provider-flexkube/flexkube/docker.go	100% <100%> (ø)
...md/terraform-provider-flexkube/flexkube/runtime.go	100% <100%> (ø)
...vider-flexkube/flexkube/hostconfiguredcontainer.go	100% <100%> (ø)
cmd/terraform-provider-flexkube/flexkube/util.go	68.93% <100%> (ø)
... and 29 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e8545...a4d0da1. Read the comment docs.

[codeclimate]

Code Climate has analyzed commit a4d0da1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 88.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.3% (-2.7% change).

View more on Code Climate.

[invidian]

Support for all features has been added. Current issues:

• destroy doesn't seem to destroy all the containers
• SSH password and private key leak into the SSH plan

[invidian]

SSH password and private key leak into the SSH plan

I have an idea how to address that, despite hashicorp/terraform-plugin-sdk#201. TL; DR we can have 2 different computed scheme. One which holds all the information needed for running, with Sensitive: true on the top, so it never shows to the user and 2nd one, almost identical to the first one, but with sanitized sensitive fields like password, private_key, perhaps config_files as well. This will allow to provide user a nice UX, without compromising the security.

[invidian]

destroy doesn't seem to destroy all the containers

This has been addressed in #75.

[invidian]

SSH password and private key leak into the SSH plan

Now also resolved.

Next step: don't serialize empty fields, so they don't pollute the output.

[invidian]

Next step: don't serialize empty fields, so they don't pollute the output.

That doesn't seem to be possible.

[invidian]

TODOs:

• move all scheme code to separate package
• add comments for all functions
• verify, that scheme works properly with other resources. E.g. apiloadbalancer has very simple configuration and should be easy to test

Regarding failing tests, it seems that when adding large amount of code, it is not possible to satisfy Code Climate total coverage change, even though the diff coverage is >90%. Codecov is doing a better job here and it compares absolute coverage with relative coverage, so the test passes. I'll perhaps disable coverage checks for codeclimate, as they doesn't seem as valuable as Codecov ones.

[invidian]

Awesome 🎉

[invidian]

Regarding failing tests, it seems that when adding large amount of code, it is not possible to satisfy Code Climate total coverage change, even though the diff coverage is >90%. Codecov is doing a better job here and it compares absolute coverage with relative coverage, so the test passes. I'll perhaps disable coverage checks for codeclimate, as they doesn't seem as valuable as Codecov ones.

Disabled.

verify, that scheme works properly with other resources. E.g. apiloadbalancer has very simple configuration and should be easy to test

Done for apiloadbalancer, as seen on the screenshot above.