Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: parboiled2: 2.2.1 → 2.4.1 #5763

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

fabianhjr
Copy link
Contributor

split from #5751

@fabianhjr fabianhjr changed the title parboiled2: 2.2.1 → 2.4.1 chore: parboiled2: 2.2.1 → 2.4.1 Apr 22, 2023
@magnus-madsen
Copy link
Member

Any impact on the running time of gradlew test?

@fabianhjr
Copy link
Contributor Author

Doing 3 runs main branch + 3 runs this branch, brb

@fabianhjr
Copy link
Contributor Author

Using time ./gradlew check

This branch:

BUILD SUCCESSFUL in 3m 50s
4 actionable tasks: 1 executed, 3 up-to-date

________________________________________________________
Executed in  231.01 secs    fish           external
   usr time    2.29 secs  590.00 micros    2.28 secs
   sys time    0.26 secs  113.00 micros    0.26 secs

BUILD SUCCESSFUL in 3m 49s
4 actionable tasks: 1 executed, 3 up-to-date

________________________________________________________
Executed in  229.64 secs    fish           external
   usr time    2.18 secs  326.00 micros    2.18 secs
   sys time    0.26 secs   63.00 micros    0.26 secs

BUILD SUCCESSFUL in 3m 45s
4 actionable tasks: 1 executed, 3 up-to-date

________________________________________________________
Executed in  226.20 secs    fish           external
   usr time    2.31 secs    0.00 micros    2.31 secs
   sys time    0.13 secs  604.00 micros    0.13 secs

@magnus-madsen
Copy link
Member

Check only builds right? I am worried about the performance of Flix itself, so it would have to be gradlew test?

@fabianhjr
Copy link
Contributor Author

Main branch:

BUILD SUCCESSFUL in 3m 45s
4 actionable tasks: 1 executed, 3 up-to-date

________________________________________________________
Executed in  225.99 secs    fish           external
   usr time    2.06 secs  385.00 micros    2.06 secs
   sys time    0.25 secs   88.00 micros    0.25 secs

BUILD SUCCESSFUL in 3m 46s
4 actionable tasks: 1 executed, 3 up-to-date

________________________________________________________
Executed in  226.85 secs    fish           external
   usr time    2.35 secs    0.00 micros    2.35 secs
   sys time    0.24 secs  495.00 micros    0.24 secs


> Task :test UP-TO-DATE
> Task :check UP-TO-DATE

BUILD SUCCESSFUL in 3m 51s
4 actionable tasks: 1 executed, 3 up-to-date

________________________________________________________
Executed in  231.71 secs    fish           external
   usr time    2.36 secs  338.00 micros    2.36 secs
   sys time    0.26 secs   80.00 micros    0.26 secs

@fabianhjr
Copy link
Contributor Author

Check only builds right? I am worried about the performance of Flix itself, so it would have to be gradlew test?

check does test too.

- flatMap06
- traverse01
- traverse02
- traverse03
- traverse04
- traverse05
- traverse06
- foldRight01
- toSoftFailure01
- toSoftFailure02
- toSoftFailure03
- recoverOne01
- recoverOne02
- recoverOne03
- recoverOne04
Run completed in 3 minutes, 50 seconds.
Total number of tests run: 1606
Suites: completed 38, aborted 0
Tests: succeeded 1606, failed 0, canceled 0, ignored 33, pending 0
All tests passed.

> Task :test UP-TO-DATE
> Task :check UP-TO-DATE

BUILD SUCCESSFUL in 3m 51s
4 actionable tasks: 1 executed, 3 up-to-date

@fabianhjr
Copy link
Contributor Author

Looks like no impact to performance.

@magnus-madsen magnus-madsen merged commit 8ee4a50 into flix:master Apr 23, 2023
11 checks passed
@fabianhjr fabianhjr deleted the update-parboiled2 branch April 23, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants