Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: scala: 2.13.5 → 2.13.11 #6078

Merged
merged 1 commit into from Jun 8, 2023

Conversation

fabianhjr
Copy link
Contributor

Release flag had to be added manually, additional context gradle/gradle#23962

Related

#4896

#4916

#4896 (comment)

Main branch

time ./gradlew clean jar                   Wed 07 Jun 2023 06:26:25 PM CST
> Task :clean
> Task :compileJava NO-SOURCE
> Task :compileScala
Unexpected javac output: warning: [options] system modules path not set in conjunction with -source 11
1 warning.

> Task :processResources NO-SOURCE
> Task :classes
> Task :jar

BUILD SUCCESSFUL in 1m 7s
3 actionable tasks: 3 executed

________________________________________________________
Executed in   68.28 secs    fish           external
   usr time    1.39 secs    0.00 micros    1.39 secs
   sys time    0.15 secs  545.00 micros    0.15 secs

This PR

time ./gradlew clean jar                   Wed 07 Jun 2023 06:46:13 PM CST
> Task :clean
> Task :compileJava NO-SOURCE
> Task :compileScala
Unexpected javac output: warning: [options] system modules path not set in conjunction with -source 11
1 warning.

> Task :processResources NO-SOURCE
> Task :classes
> Task :jar

BUILD SUCCESSFUL in 1m 1s
3 actionable tasks: 3 executed

________________________________________________________
Executed in   62.36 secs    fish           external
   usr time    1.27 secs    0.00 micros    1.27 secs
   sys time    0.13 secs  559.00 micros    0.12 secs

Release flag had to be added manually, additional context
gradle/gradle#23962
@fabianhjr
Copy link
Contributor Author

fabianhjr commented Jun 8, 2023

Test times, will update this comment with more runs

Main Branch

All tests passed.

> Task :test

BUILD SUCCESSFUL in 4m 31s
4 actionable tasks: 4 executed

________________________________________________________
Executed in  272.31 secs    fish           external
   usr time    2.38 secs  513.00 micros    2.38 secs
   sys time    0.25 secs   46.00 micros    0.25 secs

This Branch

All tests passed.

> Task :test

BUILD SUCCESSFUL in 3m 30s
4 actionable tasks: 3 executed, 1 up-to-date

________________________________________________________
Executed in  211.69 secs    fish           external
   usr time    2.27 secs  547.00 micros    2.27 secs
   sys time    0.25 secs   47.00 micros    0.25 secs
All tests passed.

> Task :test

BUILD SUCCESSFUL in 4m 13s
4 actionable tasks: 4 executed

________________________________________________________
Executed in  254.10 secs    fish           external
   usr time    2.24 secs    0.00 micros    2.24 secs
   sys time    0.24 secs  609.00 micros    0.24 secs

@magnus-madsen
Copy link
Member

Thanks @fabianhjr and thanks for checking the build times 👍

@magnus-madsen magnus-madsen merged commit f01125d into flix:master Jun 8, 2023
12 checks passed
@fabianhjr fabianhjr deleted the update-scala branch June 8, 2023 06:35
@fabianhjr
Copy link
Contributor Author

Shaved about 25 seconds from test, from ~5.75m to ~5.3m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants