Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update errors & tests for Resolver #7473

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

jaschdoc
Copy link
Member

@jaschdoc jaschdoc commented Mar 26, 2024

  • Ensure every error has at least 3 tests
  • Ensure errors occur in alphabetical order
  • Ensure errors are tagged with Recoverable or Unrecoverable
  • Ensure tests occur in alphabetical order
  • Check that test names and errors match

Related to #6817

@jaschdoc
Copy link
Member Author

This should be a failure, right?

  test("MismatchedOpArity.InvalidOpParamCount.Do.01") {
    val input =
      """
        |eff E {
        |    pub def op(): Unit
        |}
        |
        |def foo(): Unit \ E = do E.op(123)
        |""".stripMargin
    val result = compile(input, Options.TestWithLibNix)
    expectError[ResolutionError.MismatchedOpArity](result)
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant