refactor: non optional nth on Array and Vector #7526
Conversation
stetimi
force-pushed
the
nth-on-array
branch
2 times, most recently
from
f42415d
to
1a478c6
Compare
stetimi
changed the title
|
@mlutze ready to review I think |
|
Hi. I am a bit busy at the moment, but I will try to get around to it. Also just FYI: We may not be able to merge this in until there is a bit more progress on the effect side. |
Understood, I will park this for now. |
|
Why is there a file called |
A mistake - deleted, and fixed up the other comments too (thanks!) |
|
@stetimi Could you mark the comments as resolved, if they are indeed resolved :) |
|
Sure, I wasn't too sure of the protocol.
I think they're all resolved, but I'll double check and close them off when
I'm free.
…On Wed, 3 Apr 2024, 16:44 Magnus Madsen, ***@***.***> wrote:
@stetimi <https://github.com/stetimi> Could you mark the comments as
resolved, if they are indeed resolved :)
—
Reply to this email directly, view it on GitHub
<#7526 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5QUO2EESPR7UOVXEEZ7QBTY3O6PFAVCNFSM6AAAAABFRR63E6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZTHEZTOMRTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Done |
| @@ -454,7 +454,7 @@ mod Test.Exp.Regions { | |||
| MutList.push!(1, l); | |||
| MutMap.put!(1, l, Array.get(0, a)); | |||
| match MutMap.get(1, Array.get(0, a)) { | |||
| case Some(k) => MutList.nth(0, k) == Some(1) | |||
| case Some(k) => optionalNth(0, k) == Some(1) | |||
There was a problem hiding this comment.
These are just test cases, so I think we should just use get and avoid all the optionalNth stuff!
There was a problem hiding this comment.
There is no get in MutList. Should I:
- add it and delegate down to
Array.get - use
nthand put try..with statements around the relevant tests?
There was a problem hiding this comment.
Ah, I see. Not sure, let me get back to you.
|
I added one comment about simplifying the test cases. Once that is done, I will let @mlutze have a look and we can probably merge. He also needs to fix one of his projects before the merge. Thanks! |
Adding nth + IndexOutOfBounds effect, just on Array and Vector (I prefer to do it incrementally if that's acceptable).