perf: declared packages side effect free and fixed existing side effe…

…cts (#830)
floating-ui · Sep 17, 2019 · 31102ce · 31102ce
1 parent f1f4874
commit 31102ce
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/packages/popper/package.json b/packages/popper/package.json
@@ -28,6 +28,7 @@
   "module": "dist/esm/popper.js",
   "unpkg": "dist/umd/popper.min.js",
   "types": "index.d.ts",
+  "sideEffects": false,
   "scripts": {
     "prepare": "yarn build",
     "postpublish": "nuget-publish && ./bower-publish.sh",

diff --git a/packages/popper/src/utils/debounce.js b/packages/popper/src/utils/debounce.js
@@ -1,13 +1,14 @@
 import isBrowser from './isBrowser';
 
-const longerTimeoutBrowsers = ['Edge', 'Trident', 'Firefox'];
-let timeoutDuration = 0;
-for (let i = 0; i < longerTimeoutBrowsers.length; i += 1) {
-  if (isBrowser && navigator.userAgent.indexOf(longerTimeoutBrowsers[i]) >= 0) {
-    timeoutDuration = 1;
-    break;
+const timeoutDuration = (function(){
+  const longerTimeoutBrowsers = ['Edge', 'Trident', 'Firefox'];
+  for (let i = 0; i < longerTimeoutBrowsers.length; i += 1) {
+    if (isBrowser && navigator.userAgent.indexOf(longerTimeoutBrowsers[i]) >= 0) {
+      return 1;
+    }
   }
-}
+  return 0;
+}());
 
 export function microtaskDebounce(fn) {
   let called = false

diff --git a/packages/tooltip/package.json b/packages/tooltip/package.json
@@ -7,6 +7,7 @@
   "module": "./dist/esm/tooltip.js",
   "unpkg": "./dist/umd/tooltip.min.js",
   "types": "index.d.ts",
+  "sideEffects": false,
   "scripts": {
     "build": "node bundle.js",
     "prepublish": "yarn build",