Skip to content

Commit

Permalink
fix(react-native): check for virtual elements (#2743)
Browse files Browse the repository at this point in the history
  • Loading branch information
atomiks committed Jan 16, 2024
1 parent 5d025db commit 7d201f7
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 15 deletions.
5 changes: 5 additions & 0 deletions .changeset/slimy-comics-explain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@floating-ui/react-native": patch
---

fix: check for virtual elements when measuring
52 changes: 37 additions & 15 deletions packages/react-native/src/createPlatform.ts
Original file line number Diff line number Diff line change
@@ -1,40 +1,62 @@
import type {Platform} from '@floating-ui/core';
import {Dimensions} from 'react-native';
import type {Platform, VirtualElement} from '@floating-ui/core';
import {Dimensions, View} from 'react-native';

const ORIGIN = {x: 0, y: 0};

function isView(reference: View | VirtualElement): reference is View {
return 'measure' in reference;
}

export const createPlatform = ({
offsetParent,
sameScrollView = true,
scrollOffsets = ORIGIN,
}: {
offsetParent: any;
offsetParent: View;
sameScrollView: boolean;
scrollOffsets: {
x: number;
y: number;
};
}): Platform => ({
getElementRects({reference, floating}) {
getElementRects({
reference,
floating,
}: {
reference: View | VirtualElement;
floating: View;
}) {
return new Promise((resolve) => {
const onMeasure = (offsetX = 0, offsetY = 0) => {
floating.measure(
(x: number, y: number, width: number, height: number) => {
const floatingRect = {width, height, ...ORIGIN};
const method = sameScrollView ? 'measure' : 'measureInWindow';

reference[method](
(x: number, y: number, width: number, height: number) => {
const referenceRect = {
width,
height,
x: x - offsetX,
y: y - offsetY,
};
if (isView(reference)) {
reference[method](
(x: number, y: number, width: number, height: number) => {
const referenceRect = {
width,
height,
x: x - offsetX,
y: y - offsetY,
};

resolve({reference: referenceRect, floating: floatingRect});
},
);
} else {
const boundingRect = reference.getBoundingClientRect();
const referenceRect = {
width: boundingRect.width,
height: boundingRect.height,
x: boundingRect.x - offsetX,
y: boundingRect.y - offsetY,
};

resolve({reference: referenceRect, floating: floatingRect});
},
);
resolve({reference: referenceRect, floating: floatingRect});
}
},
);
};
Expand Down

0 comments on commit 7d201f7

Please sign in to comment.