New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strategy "fixed" + pinch-to-zoom generates incorrect popper position in Safari #1121
Comments
What version of Safari are you on? With 13.1 everything looks good to me. |
Oh ok thanks, I missed that step, yes I can reproduce it. |
Hey, we're running into this issue too! Looking at the example, it seems like some logic kicks-in whenever it's pinch zoomed. The logic will manually reposition popper (see attached) on scroll thereafter. I'm completely new to this project so sorry if I'm stating the obvious here but i hope it helps anyway - ha 😜 I'll have poke around today and see if i can find anything else. |
After some more digging i've found that the issue is related to this line: The result of this calculation For example:
Right now i'm thinking that the |
hmmm. appears that this is the culprit: https://stackoverflow.com/questions/6163174/detect-page-zoom-change-with-jquery-in-safari Safari wont include the zoom in |
@danieldelcore I can still reproduce it updating to |
Sorry about that, yea can still confirm that this is an issue |
I took some time to investigate this issue today, and it looks like like the issue is caused at least in part by a Webkit bug with calculating The bug is tracked in the Webkit issue tracker here, including a simpler popper example as a demonstration: https://bugs.webkit.org/show_bug.cgi?id=207089 I'll look into whether there's an alternate way we can calculate the reference's bounding box and position, and will update in a few hours |
Oh right I made that bug report 🤔 |
We see an issue with misalignment depending on whether the Safari browser chrome (top navbar, bottom toolbar) is showing or not—is this potentially a flavor of this same issue since it's about calculating bounding boxes and may depend on |
This is an amendment from @floating-ui adapted to @popperjs and flow fix floating-ui#1121 re floating-ui#1576
This is an amendment from @floating-ui adapted to @popperjs and flow fix floating-ui#1121 re floating-ui#1576
This is an amendment from @floating-ui adapted to @popperjs and flow fix floating-ui#1121 re floating-ui#1576
This is an amendment from @floating-ui adapted to @popperjs and flow fix floating-ui#1121 re floating-ui#1576
CodeSandbox demo
https://codesandbox.io/s/strange-hooks-nukkq?file=/src/index.js
Steps to reproduce the problem
What is the expected behavior?
Popper should stay on the bottom side of the reference element when scrolling.
What went wrong?
Popper goes up as far as the scroll position changes.
Any other comments?
The text was updated successfully, but these errors were encountered: