Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: Fixed strategy tooltips misaligned when browser chrome disappears on mobile #192

Closed
michael-iden opened this issue Aug 5, 2021 · 3 comments

Comments

@michael-iden
Copy link
Contributor

michael-iden commented Aug 5, 2021

Expected behavior
Tooltips always open directly adjacent to their associated element.

Actual behavior
Tooltips with the fixed positioning are misaligned from their associated element when the browser chrome disappears on mobile

Steps to reproduce the issue

  1. Perform a JSTOR search on a mobile browser. I was using Safari on iOS 14.7.1
  2. Click "Cite" to open up the citation modal
  3. Click "Copy" for one top citations (MLA, APA, Chicago)
  4. See citation is misaligned if the browser chrome is not present. Opening the citation again with the chrome present has correctly aligned tooltips

Screenshots or code
Misaligned tooltip with chrome collapsed:

Aligned tooltip with chrome visible:

Pharos version
10.5.1

Your environment

  • OS: iOS
  • Browser: Safari
  • Version: 14.7.1

Additional information
We previously tried injecting the tooltips with the default strategy (without strategy="fixed") and that had bigger issues.

@daneah daneah changed the title Fixed position tooltips misaligned when browser chrome disappears on mobile Tooltip: Fixed position tooltips misaligned when browser chrome disappears on mobile Aug 9, 2021
@daneah
Copy link
Member

daneah commented Oct 2, 2021

Joined the discussion here

@daneah daneah changed the title Tooltip: Fixed position tooltips misaligned when browser chrome disappears on mobile Tooltip: Fixed strategy tooltips misaligned when browser chrome disappears on mobile Oct 2, 2021
@daneah daneah added the hacktoberfest Hacktoberfest 2021 label Oct 17, 2021
@daneah daneah removed the hacktoberfest Hacktoberfest 2021 label Nov 11, 2021
@daneah
Copy link
Member

daneah commented Nov 7, 2022

I will be interested to see if the next release containing #434 will remedy this.

@daneah daneah self-assigned this Nov 10, 2022
@daneah
Copy link
Member

daneah commented Nov 10, 2022

@ithaka/pharos@12.15.0 is likely to fix this; will close after confirmation from the team.

@daneah daneah closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants