Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include license file in the distribution or update README.md link to the license #546

Closed
peterblazejewicz opened this issue Feb 3, 2018 · 11 comments

Comments

@peterblazejewicz
Copy link

That's minor and reflects production mode installation only. When the package is added as dependency there is no LICENSE file included. The link to the license in the README.md is relative, so it points nowhere in local installation.
I'd ask to either update the README.md (I could do this) link to point to static absolute url or just ship the license file alongside the distribution.
I'm aware that package.json comes with license type.

Thanks!

@casdevs
Copy link

casdevs commented Dec 22, 2018

We're also having the same problem. LICENSE file is missing if npm package is installed, thus it doesn't get included in our webpack's LICENSE file collection workflow...

@FezVrasta
Copy link
Member

The license is at the top of the dist files

@casdevs
Copy link

casdevs commented Dec 22, 2018

ok thanks for pointing me at this, but would it also be possible to include the LICENSE.md file for our npm package friends? see https://docs.npmjs.com/files/package.json#files

@FezVrasta
Copy link
Member

please feel free to send a PR to add this

@jquense
Copy link

jquense commented Jul 9, 2019

hey @FezVrasta newer versions of lerna will do this automatically. Would you mind pushing a new/next version with the latest lerna we'd very much appreciate it 🙏

@FezVrasta
Copy link
Member

Do you mean Lerna will prepend the license to each file?

@jquense
Copy link

jquense commented Jul 10, 2019

It will copy your top level license into the sub packages when publishing so it ends up in the npm package yeah

@FezVrasta
Copy link
Member

I see, a PR would be great, I have a flight tomorrow and I'll be out for several days so I don't have free time for this unfortunately.

@jquense
Copy link

jquense commented Jul 10, 2019

There isn't anything to PR I don't think. You would need to do a publish with the latest lerna, something I can't do. It's not pressing either, so no rush, but I wanted to let you know that lerna now supports what folks are asking for here without any additional work on your part 👍

@FezVrasta
Copy link
Member

I guess Lerna needs to be updated first, that will need a PR

@jquense
Copy link

jquense commented Jul 10, 2019

#803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants