Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(getContainingBlock): check html in while loop #1129

Merged
merged 2 commits into from Jun 10, 2020
Merged

fix(getContainingBlock): check html in while loop #1129

merged 2 commits into from Jun 10, 2020

Conversation

atomiks
Copy link
Collaborator

@atomiks atomiks commented Jun 9, 2020

@AlbertLucianto @rijkvanzanten does this fix the issue?

Closes #1128

@rollingversions
Copy link

rollingversions bot commented Jun 9, 2020 •
edited

Change Log for @popperjs/core (2.4.1 → 2.4.2)

Bug Fixes

Edit changelog

@AlbertLucianto
Copy link

@atomiks It fixed the issue on my side. Thanks!

@FezVrasta FezVrasta merged commit 38914aa into floating-ui:master Jun 10, 2020
@FezVrasta FezVrasta deleted the patch-2 branch June 10, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loop if popper is an unmounted element
3 participants
@atomiks @AlbertLucianto @FezVrasta