Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export package.json #1462

Merged
merged 1 commit into from Dec 21, 2021
Merged

export package.json #1462

merged 1 commit into from Dec 21, 2021

Conversation

alexdilley
Copy link
Contributor

A library such as rollup-plugin-svelte relies on a module's exposure of its package.json file in order to interrogate it (for a svelte field in their case, permitting it to import an uncompiled version of the distribution). It is common practice to export this file; see 'Package entry points' section of the official docs for an example.

As a consequence, exporting package.json would remove the following warning presented to consumers needing to compile Svelte components, for example:

[rollup-plugin-svelte] The following packages did not export their package.json file so we could not check the "svelte" field. If you had difficulties importing svelte components from a package, then please contact the author and ask them to export the package.json file.

There is further discussion in an equivalent PR from another library.

@rollingversions
Copy link

There is no change log for this pull request yet.

Create a changelog

@netlify
Copy link

netlify bot commented Dec 21, 2021

✔️ Deploy Preview for vibrant-gates-22c214 canceled.

🔨 Explore the source changes: e02f23b

🔍 Inspect the deploy log: https://app.netlify.com/sites/vibrant-gates-22c214/deploys/61c203bd048f330008bd8bc9

@atomiks atomiks merged commit 200f897 into floating-ui:master Dec 21, 2021
@atomiks
Copy link
Collaborator

atomiks commented Dec 21, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants