chore: [Popper] remove process.env #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no change log for this pull request yet. |
|
@atomiks would you be able to take a look at this one? Thanks! |
|
@FezVrasta can you take a look and do a release? |
FezVrasta
reviewed
May 26, 2023
FezVrasta
pushed a commit
that referenced
this pull request
May 26, 2023
Co-authored-by: atomiks <cc.glows@gmail.com>
|
Done, released to npm |
|
a massive thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an updated version of #2252
The failing CI checks are present on the
v2.xbranch without this change and are unrelated to the change. To see that you can look at the last PR merged to the branch and see that it had the same checks fail: #2229