Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NaN error when measure params are undefined #2798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

voxoram
Copy link

@voxoram voxoram commented Feb 18, 2024

No description provided.

Copy link

changeset-bot bot commented Feb 18, 2024

⚠️ No Changeset found

Latest commit: 3ce69a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for vibrant-gates-22c214 ready!

Name Link
🔨 Latest commit 3ce69a5
🔍 Latest deploy log https://app.netlify.com/sites/vibrant-gates-22c214/deploys/65d1d55dc1318d0008f7ce32
😎 Deploy Preview https://deploy-preview-2798--vibrant-gates-22c214.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@atomiks
Copy link
Collaborator

atomiks commented Feb 22, 2024

This doesn't actually address the root cause though and will still result in broken positioning.

Isn't it this Android issue?

Screenshot 2024-02-22 at 11 08 57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants