Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: replaces React_2 for React from type generation #2865

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Apr 18, 2024

Fixes #2863

  1. manually replace React_2 for React from type generation at build-api script
  2. adds build-api script as global dependency on turbo configuration
  3. bumps api-extractor to latest version
  4. adds changeset for patching:
    • @floating-ui/react
    • @floating-ui/react-dom
    • @floating-ui/react-native

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: a1429b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@floating-ui/react Patch
@floating-ui/react-dom Patch
@floating-ui/react-native Patch
website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for vibrant-gates-22c214 ready!

Name Link
🔨 Latest commit a1429b4
🔍 Latest deploy log https://app.netlify.com/sites/vibrant-gates-22c214/deploys/6620dbb304e42f0008dd97b4
😎 Deploy Preview https://deploy-preview-2865--vibrant-gates-22c214.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bsunderhus bsunderhus marked this pull request as ready for review April 18, 2024 07:27
@bsunderhus
Copy link
Contributor Author

Just wanted to make it clear, this is not an ideal solution! we should subscribe to microsoft/rushstack#2479 and once that is fixed on API extractor we can roll this PR back

@atomiks atomiks merged commit 6a3b237 into floating-ui:master Apr 19, 2024
7 checks passed
@bsunderhus bsunderhus deleted the bugfix--replaces-React_2-for-React-from-type-generation branch April 19, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate generated type aliases
2 participants