Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use visibility instead of display for tooltip #647

Merged
merged 1 commit into from Jul 1, 2018
Merged

feat: use visibility instead of display for tooltip #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/tooltip/src/index.js
View file
Open in desktop
Expand Up @@ -190,7 +190,7 @@ export default class Tooltip {

// if the tooltipNode already exists, just show it
if (this._tooltipNode) {
this._tooltipNode.style.display = '';
this._tooltipNode.style.visibility = 'visible';
this._tooltipNode.setAttribute('aria-hidden', 'false');
this.popperInstance.update();
return this;
Expand Down Expand Up @@ -261,7 +261,7 @@ export default class Tooltip {
this._isOpen = false;

// hide tooltipNode
this._tooltipNode.style.display = 'none';
this._tooltipNode.style.visibility = 'hidden';
this._tooltipNode.setAttribute('aria-hidden', 'true');

return this;
Expand Down
12 changes: 6 additions & 6 deletions packages/tooltip/tests/functional/tooltip.js
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ describe('[tooltip.js]', () => {
then(() => instance.hide());

then(() => {
expect(document.querySelector('.tooltip').style.display).toBe('none');
expect(document.querySelector('.tooltip').style.visibility).toBe('hidden');
done();
});
});
Expand All @@ -72,7 +72,7 @@ describe('[tooltip.js]', () => {
then(() => instance.toggle());

then(() => {
expect(document.querySelector('.tooltip').style.display).toBe('none');
expect(document.querySelector('.tooltip').style.visibility).toBe('hidden');
done();
});
});
Expand Down Expand Up @@ -390,7 +390,7 @@ describe('[tooltip.js]', () => {
reference.dispatchEvent(new CustomEvent('mouseenter'));
then(() => reference.dispatchEvent(new CustomEvent('mouseleave')), 200);
then(() => {
expect(document.querySelector('.tooltip').style.display).toBe('none');
expect(document.querySelector('.tooltip').style.visibility).toBe('hidden');
done();
}, 200);
});
Expand All @@ -416,7 +416,7 @@ describe('[tooltip.js]', () => {
.dispatchEvent(new CustomEvent('mouseleave'))
);
then(() => {
expect(document.querySelector('.tooltip').style.display).toBe('none');
expect(document.querySelector('.tooltip').style.visibility).toBe('hidden');
done();
}, 200);
});
Expand All @@ -443,7 +443,7 @@ describe('[tooltip.js]', () => {
);
then(() => reference.dispatchEvent(new CustomEvent('mouseenter')));
then(() => {
expect(document.querySelector('.tooltip').style.display).toBe('');
expect(document.querySelector('.tooltip').style.visibility).toBe('visible');
done();
}, 200);
});
Expand Down Expand Up @@ -493,7 +493,7 @@ describe('[tooltip.js]', () => {
reference.dispatchEvent(new CustomEvent('click'));
then(() => reference.dispatchEvent(new CustomEvent('click')));
then(() => {
expect(document.querySelector('.tooltip').style.display).toBe('none');
expect(document.querySelector('.tooltip').style.visibility).toBe('hidden');
done();
});
});
Expand Down