Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #653 Skip elements that does not have .offsetParent correctly #659

Merged
merged 1 commit into from Aug 28, 2018
Merged

fix #653 Skip elements that does not have .offsetParent correctly #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/popper/src/utils/getOffsetParent.js
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ export default function getOffsetParent(element) {
const noOffsetParent = isIE(10) ? document.body : null;

// NOTE: 1 DOM access here
let offsetParent = element.offsetParent;
let offsetParent = element.offsetParent || null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If element.offsetParent is 0, the offsetParent variable will be null. Is this the intent?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offsetParent is not a number, is an Element

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks

// Skip hidden elements which don't have an offsetParent
while (offsetParent === noOffsetParent && element.nextElementSibling) {
offsetParent = (element = element.nextElementSibling).offsetParent;
Expand Down
36 changes: 36 additions & 0 deletions packages/popper/tests/functional/core.js
View file
Open in desktop
Expand Up @@ -1319,6 +1319,42 @@ const arrowSize = 5;
});
});

it('inits a popper near the reference element when it is a child of ref and the ref is relatively positioned and the ref contains svg as a first child', done => {
if (isIE10 && !positionFixed) {
pending();
}
const ref = appendNewRef(1);
ref.style.position = 'absolute';
ref.style.margin = '0';
ref.style.padding = '0';
ref.style.top = '50px';
ref.style.left = '50px';
ref.style.height = '100px';
ref.style.width = '100px';
ref.style.background = 'green';

ref.innerHTML = `<svg fill="currentColor" preserveAspectRatio="xMidYMid meet" height="1.5em" width="1.5em" viewBox="0 0 40 40" style="vertical-align: middle;">
<g>
<path d="m20 0c-11 0-20 9-20 20 0 8.8 5.7 16.3 13.7 19 1 0.2 1.3-0.5 1.3-1 0-0.5 0-2 0-3.7-5.5 1.2-6.7-2.4-6.7-2.4-0.9-2.3-2.2-2.9-2.2-2.9-1.9-1.2 0.1-1.2 0.1-1.2 2 0.1 3.1 2.1 3.1 2.1 1.7 3 4.6 2.1 5.8 1.6 0.2-1.3 0.7-2.2 1.3-2.7-4.5-0.5-9.2-2.2-9.2-9.8 0-2.2 0.8-4 2.1-5.4-0.2-0.5-0.9-2.6 0.2-5.3 0 0 1.7-0.5 5.5 2 1.6-0.4 3.3-0.6 5-0.6 1.7 0 3.4 0.2 5 0.7 3.8-2.6 5.5-2.1 5.5-2.1 1.1 2.8 0.4 4.8 0.2 5.3 1.3 1.4 2.1 3.2 2.1 5.4 0 7.6-4.7 9.3-9.2 9.8 0.7 0.6 1.4 1.9 1.4 3.7 0 2.7 0 4.9 0 5.5 0 0.6 0.3 1.2 1.3 1 8-2.7 13.7-10.2 13.7-19 0-11-9-20-20-20z"></path>
</g>
</svg>`;
ref.appendChild(document.createTextNode('ref'));

const popper = appendNewPopper(2, 'popper', ref);
popper.style.margin = '0';
popper.style.padding = '0';

new Popper(ref, popper, {
placement: 'bottom-start',
onCreate: data => {
expect(getRect(popper).left).toBeApprox(getRect(ref).left);
expect(getRect(popper).top).toBeApprox(getRect(ref).bottom);
data.instance.destroy();
done();
},
});
});

it('checks that all the scrollable parents have an event listener attached', done => {
jasmineWrapper.innerHTML = `
<div id="s1" style="overflow: scroll; height: 300px; background: red;">
Expand Down