Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run getComputedStyle in the same context as the target element #678

Merged
merged 1 commit into from Sep 13, 2018
Merged

Run getComputedStyle in the same context as the target element #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/popper/src/utils/getOuterSizes.js
View file
Open in desktop
Expand Up @@ -6,7 +6,8 @@
* @returns {Object} object containing width and height properties
*/
export default function getOuterSizes(element) {
const styles = getComputedStyle(element);
const window = element.ownerDocument.defaultView;
const styles = window.getComputedStyle(element);
const x = parseFloat(styles.marginTop) + parseFloat(styles.marginBottom);
const y = parseFloat(styles.marginLeft) + parseFloat(styles.marginRight);
const result = {
Expand Down
3 changes: 2 additions & 1 deletion packages/popper/src/utils/getStyleComputedProperty.js
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@ export default function getStyleComputedProperty(element, property) {
return [];
}
// NOTE: 1 DOM access here
const css = getComputedStyle(element, null);
const window = element.ownerDocument.defaultView;
const css = window.getComputedStyle(element, null);
return property ? css[property] : css;
}