Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS: padding types of flip and preventOverflow #518 #750

Merged
merged 3 commits into from Jan 29, 2019

Conversation

kasparsuvi1
Copy link

Added types of padding, that are missing since #615 PR.

@kasparsuvi1 kasparsuvi1 changed the title Fix TS: padding types of flip and preventOverflow Fix TS: padding types of flip and preventOverflow #518 Jan 29, 2019
@FezVrasta
Copy link
Member

Thanks! May you do the same for the Flow types? (they are in packages/popper/index.js.flow) the syntax is the same

@kasparsuvi1
Copy link
Author

Yes, added Flow types also and made Padding props optional.

@FezVrasta FezVrasta merged commit 51a7426 into floating-ui:master Jan 29, 2019
@FezVrasta
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants