Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .js.flow definitions #829

Merged
merged 2 commits into from Oct 16, 2019
Merged

Fix .js.flow definitions #829

merged 2 commits into from Oct 16, 2019

Commits on Sep 17, 2019

  1. Fix umd flow definitions file name

    @pascalduez
    pascalduez committed Sep 17, 2019
    Copy the full SHA
    825932b View commit details
    Browse the repository at this point in the history

  2. Fix .js.flow definitions file 

    - `.js.flow` files shipped alongside the main entry point are
different from library definitions, e.g.: flow-typed.
- They need an `@flow` pragma
- They can't be wrapped in a `declare module` block
- They need to export their public types
    @pascalduez
    pascalduez committed Sep 17, 2019
    Copy the full SHA
    7577fa2 View commit details
    Browse the repository at this point in the history