fix(js): fix(js): adding missing babelrc for tsc compiled libraries

ISSUES CLOSED: nrwl#8600, nrwl#8793 ISSUES CLOSED: nrwl#8600, nrwl#8793
floroz · Apr 29, 2022 · 5c5eb4d · 5c5eb4d
1 parent fa81e3b
commit 5c5eb4d
Show file tree

Hide file tree

Showing 3 changed files with 55 additions and 0 deletions.
diff --git a/e2e/js/src/js.test.ts b/e2e/js/src/js.test.ts
@@ -46,6 +46,12 @@ describe('js e2e', () => {
       'match the cache'
     );
 
+    const babelRc = readJson(`libs/${lib}/.babelrc`);
+    expect(babelRc.plugins).toBeUndefined();
+    expect(babelRc.presets).toStrictEqual([
+      ['@nrwl/web/babel', { useBuiltIns: 'usage' }],
+    ]);
+
     expect(runCLI(`build ${lib}`)).toContain('Done compiling TypeScript files');
     checkFilesExist(
       `dist/libs/${lib}/README.md`,

diff --git a/packages/js/src/generators/library/library.spec.ts b/packages/js/src/generators/library/library.spec.ts
@@ -162,6 +162,27 @@ describe('lib', () => {
               `);
       });
 
+      it('should create a local .babelrc configuration', async () => {
+        await libraryGenerator(tree, {
+          ...defaultOptions,
+          name: 'myLib',
+        });
+
+        const babelRc = readJson(tree, 'libs/my-lib/.babelrc');
+        expect(babelRc).toMatchInlineSnapshot(`
+          Object {
+            "presets": Array [
+              Array [
+                "@nrwl/web/babel",
+                Object {
+                  "useBuiltIns": "usage",
+                },
+              ],
+            ],
+          }
+        `);
+      });
+
       it('should extend from root tsconfig.json when no tsconfig.base.json', async () => {
         tree.rename('tsconfig.base.json', 'tsconfig.json');
 
@@ -222,6 +243,7 @@ describe('lib', () => {
         expect(tree.exists('libs/my-dir/my-lib/src/index.ts')).toBeTruthy();
         expect(tree.exists(`libs/my-dir/my-lib/.eslintrc.json`)).toBeTruthy();
         expect(tree.exists(`libs/my-dir/my-lib/package.json`)).toBeFalsy();
+        expect(tree.exists(`libs/my-dir/my-lib/.babelrc`)).toBeTruthy();
       });
 
       it('should update workspace.json', async () => {
@@ -771,6 +793,17 @@ describe('lib', () => {
         expect(tree.exists('libs/my-lib/.lib.swcrc')).toBeTruthy();
       });
 
+      it('should not generate a .babelrc for swc', async () => {
+        await libraryGenerator(tree, {
+          ...defaultOptions,
+          name: 'myLib',
+          buildable: true,
+          compiler: 'swc',
+        });
+
+        expect(tree.exists('libs/my-lib/.babelrc')).toBeFalsy();
+      });
+
       it('should setup jest project using swc', async () => {
         await libraryGenerator(tree, {
           ...defaultOptions,

diff --git a/packages/js/src/generators/library/library.ts b/packages/js/src/generators/library/library.ts
@@ -177,6 +177,18 @@ function updateTsConfig(tree: Tree, options: NormalizedSchema) {
   });
 }
 
+function addBabelConfig(tree: Tree, options: NormalizedSchema) {
+  const filename = '.babelrc';
+  const babelrc = {
+    presets: [['@nrwl/web/babel', { useBuiltIns: 'usage' }]],
+  };
+
+  tree.write(
+    join(options.projectRoot, filename),
+    JSON.stringify(babelrc, null, 2)
+  );
+}
+
 function createFiles(tree: Tree, options: NormalizedSchema, filesDir: string) {
   const { className, name, propertyName } = names(options.name);
 
@@ -201,6 +213,10 @@ function createFiles(tree: Tree, options: NormalizedSchema, filesDir: string) {
     addSwcConfig(tree, options.projectRoot);
   }
 
+  if (options.compiler !== 'swc') {
+    addBabelConfig(tree, options);
+  }
+
   if (options.unitTestRunner === 'none') {
     tree.delete(
       join(options.projectRoot, 'src/lib', `${options.fileName}.spec.ts`)