Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styled-components] Fix tests #4029

Merged

Conversation

Brianzchen
Copy link
Member

@Brianzchen Brianzchen commented Feb 23, 2021

Other notes:

@Brianzchen
Copy link
Member Author

So far only v2/3 are failing but they look completely broken to me

@Brianzchen Brianzchen marked this pull request as ready for review May 1, 2021 06:01
@Brianzchen
Copy link
Member Author

@gantoine @pascalduez @AndrewSouthpaw I haven't really touched this PR for a while but the comment above is still true, v2/3 complicated to fix and so the tests break. But this should probably get reviewed so that issues like #4068 and many other issues related to styled-components can continue. Would like your thoughts on the matter

@Brianzchen Brianzchen changed the title [styled-components] Fix tests - WIP [styled-components] Fix tests May 1, 2021
@AndrewSouthpaw
Copy link
Contributor

Hey @Brianzchen ! Sorry for the radio silence, this month was a pretty full one for me. This looks good.

@AndrewSouthpaw AndrewSouthpaw merged commit 145462e into flow-typed:master May 27, 2021
@Brianzchen Brianzchen deleted the styled-components-test-fix branch May 27, 2021 21:43
@Brianzchen
Copy link
Member Author

I doubt anyone would maintain v2/3 anymore though we shouldn't delete old lib defs. I'm wondering if you have any idea of how we could proceed? Maybe we delete breaking tests from these versions so that don't break tests when maintaining styled-components?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants